Remove error mixin usages #28149
Merged
Remove error mixin usages #28149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
crisbeto
requested review from
mmalerba,
zarend,
andrewseguin,
devversion and
josephperrott
as code owners
crisbeto
force-pushed
the
error-mixin-removal
branch
3 times, most recently
from
505aca2
to
b562169
Compare
Moves the error tracking behavior into a separate class that we can use instead of `mixinErrorState`.
Replaces the final TypeScript mixin used by `MatInput` with an internal class.
Replaces the final TypeScript mixin used by `MatSelect` with an internal class.
Replaces the final TypeScript mixin used by `MatChipGrid` with an internal class.
Replaces the final TypeScript mixin used by `MatStartDate` and `MatEndDate` with an internal class.
crisbeto
force-pushed
the
error-mixin-removal
branch
from
b562169
to
2c16c43
Compare
crisbeto
added
target: minor
wagnermaciel
approved these changes
Nov 20, 2023
crisbeto
removed request for
devversion,
zarend,
josephperrott,
mmalerba and
andrewseguin
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Nov 24, 2023
The changes from angular#28149 appear to have triggered an error when `mat-chip-grid` is used inside of a `mat-form-field` and optimized with Closure compiler in a configuration that uses type information to do property renaming. These changes work around the issue within `mat-form-field`.
crisbeto
added a commit
that referenced
this pull request
Nov 24, 2023
The changes from #28149 appear to have triggered an error when `mat-chip-grid` is used inside of a `mat-form-field` and optimized with Closure compiler in a configuration that uses type information to do property renaming. These changes work around the issue within `mat-form-field`.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all remaining usages of the error mixin by moving the functionality into a new class that is used internally inside the components. This allows us to further clean up some boilerplate and a hacky workaround in the chip grid.