Cdk tree revamp tabindex #28136
Merged
Cdk tree revamp tabindex #28136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarend
commented
Nov 16, 2023
zarend
commented
Nov 16, 2023
zarend
force-pushed
the
cdk-tree-revamp_tabindex
branch
from
e9cc395
to
32e1c74
Compare
zarend
force-pushed
the
cdk-tree-revamp_tabindex
branch
3 times, most recently
from
04a3fbd
to
ba4bb98
Compare
zarend
requested review from
jelbourn,
andrewseguin and
devversion
as code owners
BobobUnicorn
approved these changes
Nov 29, 2023
zarend
force-pushed
the
cdk-tree-revamp_tabindex
branch
2 times, most recently
from
3c53ed8
to
4bce052
Compare
Fix miscelaneous focus management details in response to PR feedback. * omit tabindex attribute on role="tree" element * Remove TreeKeyManagerStrategy#onInitialFocus * Implement focus/unfocus pattern for TreeKeyManagerOption and use a binding to set tabindex on tree nodes * algin with https://www.w3.org/WAI/ARIA/apg/practices/keyboard-interface/#focusabilityofdisabledcontrols * Add tree-using-legacy-key-manager.spec.ts
zarend
force-pushed
the
cdk-tree-revamp_tabindex
branch
from
4bce052
to
e744e57
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.