feat(material-experimental/theming): add M3 grid-list support #28131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
approved these changes
Nov 16, 2023
| @if inspection.get-theme-version($theme) == 1 { | ||
| @include _theme-from-tokens(inspection.get-theme-tokens($theme, base)); | ||
| } | ||
| @else {} |
There was a problem hiding this comment.
nit: should we remove the empty @else?
There was a problem hiding this comment.
ehh, I've been leaving it as a hint if we need to add any M2 tokens, that they belong in the else (I suspect we will add more tokens for some of the components in order to fully express M3, and those will need corresponding M2 values)
mmalerba
added a commit
that referenced
this pull request
Nov 16, 2023
(cherry picked from commit f67c871)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.