Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cdk tree revamp pr fixes 1 #28108

Closed
wants to merge 15 commits into from
Closed

Cdk tree revamp pr fixes 1 #28108

wants to merge 15 commits into from

Conversation

zarend
Copy link
Contributor

@zarend zarend commented Nov 10, 2023

No description provided.

crisbeto and others added 15 commits November 8, 2023 13:38
@crisbeto
docs: release notes for the v16.2.12 release
9365dab
@crisbeto
build: update to Angular v17 final (angular#28076)
2e466be 
Updates the repo to the final release of Angular v17.
@crisbeto
docs: release notes for the v17.0.0 release
c38e72f
@devversion
ci: publish snapshots to correct builds repository branch (angular#28083
7f301a8 
)

With angular@1d67721, the snapshots CI job
was migrated from CircleCI to GitHub actions, but the underlying scripts
were not updated to no longer depend on CircleCI specifics.
@mmalerba
feat(material-experimental/theming): add M3 slide-toggle support (ang…
76cda42 
…ular#28014)
@zarend
Merge remote-tracking branch 'upstream/main' into cdk-tree-revamp
9b4d2d5
@zarend
rename LegacyTreeKeyManager to NoopTreeKeyManager
7603bb6
@zarend
* remove unnecessary comment
aa8d043 
 * fix JSDoc comment syntax
@zarend
* move type definitions in tree-key-manager.ts to a new file,
b4f402e 
   tree-key-manager-strategy.ts
@zarend
* remove isNotNullish
21bef41
@zarend
* consolidate event handling code in CdkTreeNodeToggle
ada6437
@zarend
* remove unnecessary type coerscion
927fbba
@zarend
* simply logic for detecting TreeControlMissingErro and MultipleTree…
72105c0 
…ControlsError
@zarend
* adopt Input transform
502850d
@zarend
* remove unnecessary nesting in _updateActiveItemIndex
60e634a
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: docs Related to the documentation area: build & ci Related the build and CI infrastructure of the project labels Nov 10, 2023
@zarend zarend closed this Nov 10, 2023
@zarend zarend deleted the cdk-tree-revamp_pr-fixes-1 branch November 10, 2023 22:04
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion Awaiting requested review from devversion devversion will be requested when the pull request is marked ready for review devversion is a code owner

@josephperrott josephperrott Awaiting requested review from josephperrott josephperrott will be requested when the pull request is marked ready for review josephperrott is a code owner

@jelbourn jelbourn Awaiting requested review from jelbourn jelbourn will be requested when the pull request is marked ready for review jelbourn is a code owner

@andrewseguin andrewseguin Awaiting requested review from andrewseguin andrewseguin will be requested when the pull request is marked ready for review andrewseguin is a code owner

@mmalerba mmalerba Awaiting requested review from mmalerba mmalerba will be requested when the pull request is marked ready for review mmalerba is a code owner

@crisbeto crisbeto Awaiting requested review from crisbeto crisbeto will be requested when the pull request is marked ready for review crisbeto is a code owner

Assignees
No one assigned
Labels
area: build & ci Related the build and CI infrastructure of the project area: docs Related to the documentation detected: feature PR contains a feature commit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zarend @crisbeto @devversion @mmalerba