fix(cdk/menu): unable to close child menu with disabled items when us… #28097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behzadmehrabi
force-pushed
the
fix-cdk-menu-unable-to-close
branch
from
6edf06b
to
b17ba55
Compare
|
@crisbeto I can't figure out why |
|
The check was broken on the |
behzadmehrabi
force-pushed
the
fix-cdk-menu-unable-to-close
branch
2 times, most recently
from
b96895b
to
169d248
Compare
…ing keyboard Fixes the issue where the child menu remained open when all of its items were disabled.
behzadmehrabi
force-pushed
the
fix-cdk-menu-unable-to-close
branch
from
169d248
to
b5129f4
Compare
crisbeto
reviewed
Nov 17, 2023
| // If there's no active item at this point, it means that all the items are disabled. | ||
| // Move focus to the menuPanel panel so keyboard events like Escape and closing child menus using arrow keys still works. | ||
| // Also, this will give _some_ feedback to screen readers. | ||
| if (!this.nativeElement.contains(document.activeElement)) { |
There was a problem hiding this comment.
Instead of going to the DOM, I think that we can check keyManager.activeItem === null here.
There was a problem hiding this comment.
Sorry for the delayed response, I tried it but didn't work, the keyManager.activeItem at this point is the child menu trigger button.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27403.