-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material/button): fix raised button line-height #28073
fix(material/button): fix raised button line-height #28073
Conversation
6ed8dd9
to
10e3678
Compare
@@ -168,6 +168,10 @@ | |||
@include mdc-helpers.using-mdc-typography($theme) { | |||
@include mdc-button.without-ripple($query: mdc-helpers.$mdc-typography-styles-query); | |||
} | |||
|
|||
.mat-mdc-raised-button { | |||
line-height: inherit; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we tried putting this in the component base styles? I'm fine with having it here if it helps us land the changes, but it technically should be in the base.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I tried putting these in the components base styles, I also ran into an issue where some teams just aren't pulling in theme styles. As you can imagine, setting the line-height: inherit
at a slightly higher specificity there resulted in a bunch of failures, so I moved the override over to the theme styles. This way, the override is right after the line-height: 36px
coming from the without-ripple
mixin on line 169, and it doesn't get pulled in for teams that aren't pulling in theme styles
Also, this will only be here temporarily. I need to land this change for each of the variants so that ripping out the without-ripple
is feasible. Once these have landed, I'll then swap the without-ripple
for our tokens and then I can remove these styles altogether
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. It's not a blocker.
10e3678
to
ad4bdea
Compare
(cherry picked from commit 59c8bb9)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.