fix(material/button): fix raised button line-height #28073
Conversation
wagnermaciel
force-pushed
the
raised-button-typography
branch
from
6ed8dd9
to
10e3678
Compare
wagnermaciel
added
the
target: rc
| @@ -168,6 +168,10 @@ | |||
| @include mdc-helpers.using-mdc-typography($theme) { | |||
| @include mdc-button.without-ripple($query: mdc-helpers.$mdc-typography-styles-query); | |||
| } | |||
|
|
|||
| .mat-mdc-raised-button { | |||
| line-height: inherit; | |||
There was a problem hiding this comment.
Have we tried putting this in the component base styles? I'm fine with having it here if it helps us land the changes, but it technically should be in the base.
There was a problem hiding this comment.
When I tried putting these in the components base styles, I also ran into an issue where some teams just aren't pulling in theme styles. As you can imagine, setting the line-height: inherit at a slightly higher specificity there resulted in a bunch of failures, so I moved the override over to the theme styles. This way, the override is right after the line-height: 36px coming from the without-ripple mixin on line 169, and it doesn't get pulled in for teams that aren't pulling in theme styles
Also, this will only be here temporarily. I need to land this change for each of the variants so that ripping out the without-ripple is feasible. Once these have landed, I'll then swap the without-ripple for our tokens and then I can remove these styles altogether
There was a problem hiding this comment.
Makes sense. It's not a blocker.
wagnermaciel
force-pushed
the
raised-button-typography
branch
from
10e3678
to
ad4bdea
Compare
wagnermaciel
added
action: merge
(cherry picked from commit 59c8bb9)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.