Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch docs, tests and dev apps to new control flow #28058

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 6, 2023

Updates all of the tests, docs and live examples to use the new Angular control flow. This both showcases the new feature and serves as a way to validate that it works against our codebase.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge: preserve commits When the PR is merged, a rebase and merge should be performed target: rc This PR is targeted for the next release-candidate labels Nov 6, 2023
@angular-robot angular-robot bot added area: docs Related to the documentation area: build & ci Related the build and CI infrastructure of the project labels Nov 6, 2023
Switches all of our tests to use the new control flow in order to validate that it works as expected.
Switches the dev and e2e apps to use the new control flow.
Switches the docs examples to use the new control flow instead of `*ngIf`, `*ngFor` and `*ngSwitch`.
Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phew you're on a roll

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Nov 6, 2023
@crisbeto crisbeto merged commit 99b62ba into angular:main Nov 6, 2023
25 of 27 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project area: docs Related to the documentation merge: preserve commits When the PR is merged, a rebase and merge should be performed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants