-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove most remaining usages of TypeScript mixins #28048
Conversation
e6ff1ba
to
59a9342
Compare
a902f24
to
2c2e657
Compare
2c2e657
to
803d830
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should consider deprecating and removing these mixins in the future
ddbf094
to
0b4310f
Compare
Reworks the chips to use input transforms instead of mixins.
Reworks the select to use input transforms instead of mixins.
Reworks the expansion panel to use input transforms instead of mixins.
Reworks the CDK tree to use input transforms instead of getters and setters.
Reworks the Material tree to use input transforms instead of mixins.
Reworks the radio button to use input transforms instead of mixins.
Reworks the tabs to use input transforms instead of mixins.
Reworks the slider to use input transforms instead of mixins.
Reworks the sort header to use input transforms instead of mixins.
Reworks the datepicker to use input transforms instead of mixins.
Reworks the paginator to use input transforms instead of mixins.
Reworks the toolbar to use input transforms instead of mixins.
Reworks the icon to use input transforms instead of mixins.
Reworks the stepper to use input transforms instead of mixins.
Reworks the progress spinner to use input transforms instead of mixins.
Reworks the progress bar to use input transforms instead of mixins.
0b4310f
to
74dfca2
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
These changes remove all the remaining usages of
mixinColor
,mixinDisabled
,mixinDisableRipple
andmixinTabindex
in favor of using input transforms and host bindings. There are still some usages ofmixinErrorState
andmixinInitialized
that have to be migrated separately.I've made this refactor, because:
mixinColor
, because it uses direct DOM manipulation. This is problematic for future hydration and SSR efforts.mixinDisabled
,mixinDisableRipple
andmixinTabindex
were only used for input coercion which can be replaced with input transforms.