Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(material/chips): expose _chipGrid in MatChipInput and add a stream of chip removal events #28013

Merged
merged 1 commit into from
Oct 27, 2023
Merged

feat(material/chips): expose _chipGrid in MatChipInput and add a stream of chip removal events #28013

merged 1 commit into from
Oct 27, 2023

Conversation

clamli
Copy link
Contributor

@clamli clamli commented Oct 26, 2023 •
edited
Loading

The original FR is this (#28012). There are two changes in this PR,

  1. Expose _chipGrid from MatChipInput
  2. Add a stream of chip removal events in MatChipSet

@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Oct 26, 2023
@clamli clamli changed the title feat(material/chips): expose _chipGrid in MatChipInput and add a stream of chip removal events (#28012) feat(material/chips): expose _chipGrid in MatChipInput and add a stream of chip removal events Oct 26, 2023
@clamli clamli force-pushed the chips branch 2 times, most recently from 4039ba7 to c120a2b Compare October 26, 2023 21:29
mmalerba
mmalerba approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Oct 26, 2023
@mmalerba mmalerba merged commit 6719168 into angular:main Oct 27, 2023
22 of 24 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto left review comments

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clamli @crisbeto @mmalerba