Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(material/button): handle disabled state of icon buttons through tokens #27988

Merged
merged 1 commit into from
Oct 24, 2023
Merged

refactor(material/button): handle disabled state of icon buttons through tokens #27988

merged 1 commit into from
Oct 24, 2023

Conversation

crisbeto
Copy link
Member

  • Fixes that icon buttons weren't using the right token for disabled state.
  • Fixes that the specificity of the icon button disabled styles was really high.
  • Moves the logic for generating the palette tokens into the icon button tokens file.
  • Fixes one place where we were referencing a token directly instead of using the API to generate the name.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate labels Oct 24, 2023
@crisbeto crisbeto self-assigned this Oct 24, 2023
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Oct 24, 2023
@crisbeto
refactor(material/button): handle disabled state of icon buttons thro…
a706879 
…ugh tokens

* Fixes that icon buttons weren't using the right token for disabled state.
* Fixes that the specificity of the icon button disabled styles was really high.
* Moves the logic for generating the palette tokens into the icon button tokens file.
* Fixes one place where we were referencing a token directly instead of using the API to generate the name.
@crisbeto crisbeto added target: patch This PR is targeted for the next patch release target: major This PR is targeted for the next major release target: rc This PR is targeted for the next release-candidate and removed target: rc This PR is targeted for the next release-candidate target: patch This PR is targeted for the next patch release target: major This PR is targeted for the next major release labels Oct 24, 2023
@crisbeto
Copy link
Member Author

crisbeto commented Oct 24, 2023 •
edited
Loading

Merging this one manually via the UI since somehow it's conflicting with 17.0.x, but not main. Will open another PR to cherry-pick the changes.

@crisbeto crisbeto merged commit 13b8ad1 into angular:main Oct 24, 2023
34 of 36 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@wagnermaciel wagnermaciel wagnermaciel approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @mmalerba @wagnermaciel