Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk/accordion): add CDK_ACCORDION export #27981

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

babiakrs
Copy link
Contributor

Fixes an issue in the Angular CDK accordion component where CDK_ACCORDION injection token cannot be imported from @angular/cdk/accordion. This is because public-api.ts did not contain CDK_ACCORDION export.

Fixes an issue in the Angular CDK `accordion` component where `CDK_ACCORDION` injection token cannot be imported from `@angular/cdk/accordion`. This is because `public-api.ts` did not contain `CDK_ACCORDION` export.
@crisbeto
Copy link
Member

It looks like the CI checks are failing. You need to run yarn approve-api cdk/accordion and commit the result.

@babiakrs
Copy link
Contributor Author

Just pushed changes. Thank you, I missed this step

@crisbeto crisbeto self-assigned this Oct 31, 2023
@crisbeto crisbeto removed the request for review from andrewseguin October 31, 2023 17:30
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Oct 31, 2023
@crisbeto crisbeto merged commit ab8d7e5 into angular:main Oct 31, 2023
24 of 26 checks passed
crisbeto pushed a commit that referenced this pull request Oct 31, 2023
* fix(cdk/accordion): add `CDK_ACCORDION` export

Fixes an issue in the Angular CDK `accordion` component where `CDK_ACCORDION` injection token cannot be imported from `@angular/cdk/accordion`. This is because `public-api.ts` did not contain `CDK_ACCORDION` export.

* fix(cdk/accordion): update public api

(cherry picked from commit ab8d7e5)
crisbeto pushed a commit that referenced this pull request Oct 31, 2023
* fix(cdk/accordion): add `CDK_ACCORDION` export

Fixes an issue in the Angular CDK `accordion` component where `CDK_ACCORDION` injection token cannot be imported from `@angular/cdk/accordion`. This is because `public-api.ts` did not contain `CDK_ACCORDION` export.

* fix(cdk/accordion): update public api

(cherry picked from commit ab8d7e5)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants