-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cdk/accordion): add CDK_ACCORDION
export
#27981
fix(cdk/accordion): add CDK_ACCORDION
export
#27981
Conversation
Fixes an issue in the Angular CDK `accordion` component where `CDK_ACCORDION` injection token cannot be imported from `@angular/cdk/accordion`. This is because `public-api.ts` did not contain `CDK_ACCORDION` export.
It looks like the CI checks are failing. You need to run |
Just pushed changes. Thank you, I missed this step |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* fix(cdk/accordion): add `CDK_ACCORDION` export Fixes an issue in the Angular CDK `accordion` component where `CDK_ACCORDION` injection token cannot be imported from `@angular/cdk/accordion`. This is because `public-api.ts` did not contain `CDK_ACCORDION` export. * fix(cdk/accordion): update public api (cherry picked from commit ab8d7e5)
* fix(cdk/accordion): add `CDK_ACCORDION` export Fixes an issue in the Angular CDK `accordion` component where `CDK_ACCORDION` injection token cannot be imported from `@angular/cdk/accordion`. This is because `public-api.ts` did not contain `CDK_ACCORDION` export. * fix(cdk/accordion): update public api (cherry picked from commit ab8d7e5)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes an issue in the Angular CDK
accordion
component whereCDK_ACCORDION
injection token cannot be imported from@angular/cdk/accordion
. This is becausepublic-api.ts
did not containCDK_ACCORDION
export.