fix(material/checkbox): add aria-checked #27970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another option is to change Material Web's styling to use EDIT: This was not possible since indeterminate property cannot be set via HTML, necessary for the other framework |
crisbeto
reviewed
Oct 20, 2023
andrewseguin
added
the
target: patch
crisbeto
approved these changes
Oct 23, 2023
andrewseguin
added a commit
that referenced
this pull request
Oct 23, 2023
* fix(material/checkbox): add aria-checked * fix(material/checkbox): move aria-checked test (cherry picked from commit cc2f2c5)
andrewseguin
added a commit
that referenced
this pull request
Oct 23, 2023
* fix(material/checkbox): add aria-checked * fix(material/checkbox): move aria-checked test (cherry picked from commit cc2f2c5)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding aria-checked to the checkbox input. Technically this is redundant but Material Web's new styling requires indeterminate mode to have aria-checked=mixed when enabled.