Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(cdk/a11y): add example of LiveAnnouncer inside dialog #27944

Merged
merged 1 commit into from
Oct 17, 2023
Merged

docs(cdk/a11y): add example of LiveAnnouncer inside dialog #27944

merged 1 commit into from
Oct 17, 2023

Conversation

zarend
Copy link
Contributor

@zarend zarend commented Oct 13, 2023

Update the live-announcer demo in the dev-app. Add an example of calling LiveAnnouncer inside of a Dialog. Create another way to reproduce issues with using live regions inside an aria-modal (#22733).

@zarend
docs(cdk/a11y): add example of LiveAnnouncer inside dialog
209beab 
Update the live-announcer demo in the dev-app. Add an example of calling
LiveAnnouncer inside of a Dialog. Create another way to reproduce issues with
using live regions inside an aria-modal (angular#22733).
@zarend zarend added Accessibility This issue is related to accessibility (a11y) docs This issue is related to documentation area: cdk/a11y labels Oct 13, 2023
@zarend zarend requested a review from crisbeto October 13, 2023 23:30
@angular-robot angular-robot bot added the area: docs Related to the documentation label Oct 13, 2023
@zarend zarend marked this pull request as ready for review October 13, 2023 23:38
@zarend zarend requested a review from jelbourn as a code owner October 13, 2023 23:38
@zarend zarend added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Oct 17, 2023
@zarend zarend removed the request for review from jelbourn October 17, 2023 17:37
@zarend zarend merged commit 504ff7f into angular:main Oct 17, 2023
34 checks passed
zarend added a commit that referenced this pull request Oct 17, 2023
@zarend
docs(cdk/a11y): add example of LiveAnnouncer inside dialog (#27944)
ff32b51 
Update the live-announcer demo in the dev-app. Add an example of calling
LiveAnnouncer inside of a Dialog. Create another way to reproduce issues with
using live regions inside an aria-modal (#22733).

(cherry picked from commit 504ff7f)
zarend added a commit that referenced this pull request Oct 17, 2023
@zarend
docs(cdk/a11y): add example of LiveAnnouncer inside dialog (#27944)
11eecc1 
Update the live-announcer demo in the dev-app. Add an example of calling
LiveAnnouncer inside of a Dialog. Create another way to reproduce issues with
using live regions inside an aria-modal (#22733).

(cherry picked from commit 504ff7f)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker area: cdk/a11y area: docs Related to the documentation docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zarend @crisbeto