Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(material/form-field): use correct input color in custom control example #27903

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

json-derulo
Copy link
Contributor

@json-derulo json-derulo commented Oct 5, 2023

In the Form Field docs, there is an example how to create a custom control. In this example, the inputs of the custom control don't inherit the text color from the form field. In light mode, this is just fine. But when switching to a dark mode theme, the color of the inputs default to the browser default (black):

image

It should inherit the color from the form field, which is fixed by this PR.

@angular-robot angular-robot bot added the area: docs Related to the documentation label Oct 5, 2023
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Oct 6, 2023
@crisbeto crisbeto merged commit e463e93 into angular:main Oct 6, 2023
26 checks passed
crisbeto pushed a commit that referenced this pull request Oct 6, 2023
@crisbeto crisbeto self-assigned this Oct 6, 2023
@json-derulo json-derulo deleted the form-field-example-input-color branch October 6, 2023 12:36
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants