Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(material/button): switch raised button to tokens theming API #27813

Merged
merged 1 commit into from
Sep 27, 2023
Merged

refactor(material/button): switch raised button to tokens theming API #27813

merged 1 commit into from
Sep 27, 2023

Conversation

wagnermaciel
Copy link
Contributor

No description provided.

@wagnermaciel wagnermaciel marked this pull request as ready for review September 20, 2023 02:41
@wagnermaciel wagnermaciel requested review from crisbeto and removed request for andrewseguin September 20, 2023 02:47
crisbeto
crisbeto approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of notes, but otherwise LGTM.

src/material/button/_button-theme.scss Outdated Show resolved Hide resolved
src/material/core/tokens/m2/mdc/_button-protected.scss Outdated Show resolved Hide resolved
@wagnermaciel wagnermaciel added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release target: minor This PR is targeted for the next minor release and removed target: major This PR is targeted for the next major release target: minor This PR is targeted for the next minor release labels Sep 26, 2023
@wagnermaciel wagnermaciel removed the request for review from crisbeto September 27, 2023 13:52
@wagnermaciel wagnermaciel merged commit f2b4a04 into angular:main Sep 27, 2023
22 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wagnermaciel @crisbeto @mmalerba