refactor(material/button): switch to tokens theming API #27784
Conversation
wagnermaciel
requested review from
mmalerba and
andrewseguin
as code owners
|
|
||
| // Tokens that can be configured through Angular Material's typography theming API. | ||
| @function get-typography-tokens($theme) { | ||
| @return (); |
There was a problem hiding this comment.
The typography and density styles are still using MDC's old API. Shouldn't we switch them over as well?
There was a problem hiding this comment.
Yeah this is what I was trying to bring up in standup but didn't have time to dive into. Currently all button variants are relying on the same styles for density & typography. I asked if I should split those out and Andrew said he was ok with landing this without doing so
There was a problem hiding this comment.
That said, I don't really know if I was able to explain the situation in the short time we had during standup. I'll ping Andrew and see if he can weigh in here
There was a problem hiding this comment.
That's at least what we've been doing when converting the other components to tokens. For the filled button specifically it looks like we have these 5 tokens for the typography: label-text-font, label-text-size, label-text-tracking, label-text-transform, label-text-weight and the container-height token for the density.
There was a problem hiding this comment.
Had a chat with Wagner - it'll be a bit easier to land the typography changes across all the variants at once after these PRs land. It'll just be a different iterative approach that reaches the same goal in the end (remove the old MDC mixins)
There was a problem hiding this comment.
Alright, I wanted to make sure that we do it before we consider the button as migrated.
wagnermaciel
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.