Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix patch branch #27751

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Fix patch branch #27751

merged 2 commits into from
Aug 31, 2023

Conversation

crisbeto
Copy link
Member

Cherry picks a couple of commits to fix the CI failures in the patch branch.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge: preserve commits When the PR is merged, a rebase and merge should be performed labels Aug 31, 2023
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Aug 31, 2023
josephperrott
josephperrott approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crisbeto and others added 2 commits August 31, 2023 21:21
@crisbeto
build: fix lint warning
a3af78d 
Fixes a lint warning coming in from main.
@crisbeto
build: bump node version (angular#27720)
0c051cc 
Updates to a slightly newer version of Node. We need this, because the automated Lighthouse audits require at least version 18.16.0.
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Aug 31, 2023
@crisbeto crisbeto merged commit f1d7757 into angular:16.2.x Aug 31, 2023
15 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@devversion devversion Awaiting requested review from devversion devversion is a code owner

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project merge: preserve commits When the PR is merged, a rebase and merge should be performed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crisbeto @josephperrott