Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/tabs): add aria-hidden to inactive tabs #27742

Merged
merged 1 commit into from
Sep 4, 2023

Commits on Aug 31, 2023

  1. fix(material/tabs): add aria-hidden to inactive tabs

    Make accessibility fix for Tabs component. Add `aria-hidden="true"` to
    inactive tab panels. Fix issue where chromevox would read the names of
    inactive tab panels when navigating past the active tab panel (angular#27741).
    Fix this by adding `aria-hidden="true"` to inactive tab panels to
    exclude them from the a11y tree.
    
    I believe what was happening is that the inactive tab panels had an
    aria-labelled by references that pointed to the tab header. Existing
    behavior seems to be that Chromevox was following the aria-labelledby
    references and announcing the labels of the inactive tabs. With this
    commit applied, Chromevox no longer reads panels of inactive tabs.
    
    Fix angular#27741
    zarend committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    374d6af View commit details
    Browse the repository at this point in the history