Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/table): Simultaneous Row Expansion Issue in MatTab with Nested MatTable Component #27659

Merged

Conversation

kharazian
Copy link
Contributor

Resolved a bug causing simultaneous row expansion in a MatTab when a nested MatTable component with expandable rows was used. The problem stemmed from animations triggered by the parent's visibility set to 'hidden.'

Solution: Incorporated void state within animations to reset them after eraseStyles function execution, ensuring consistent row expansion behavior within MatTabs.

Fix #27560

…nested table

Resolved a bug causing simultaneous row expansion in a MatTab when a nested MatTable component
with expandable rows was used. The problem stemmed from animations triggered by the parent's
visibility set to 'hidden.'

Solution: Incorporated void state within animations to reset them after eraseStyles function
execution, ensuring consistent row expansion behavior within MatTabs.

Fixes angular#27560
@kharazian kharazian force-pushed the fix-expandable-mat-table-in-mat-tab-issue branch from e37c5b3 to 5252b8b Compare September 27, 2023 12:58
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto self-assigned this Nov 9, 2023
@crisbeto crisbeto added docs This issue is related to documentation action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed labels Nov 9, 2023
@crisbeto crisbeto removed the request for review from andrewseguin November 9, 2023 05:15
@crisbeto crisbeto merged commit ed45f44 into angular:main Nov 9, 2023
12 of 14 checks passed
crisbeto pushed a commit that referenced this pull request Nov 9, 2023
… Nested MatTable Component (#27659)

Resolved a bug causing simultaneous row expansion in a MatTab when a nested MatTable component
with expandable rows was used. The problem stemmed from animations triggered by the parent's
visibility set to 'hidden.'

Solution: Incorporated void state within animations to reset them after eraseStyles function
execution, ensuring consistent row expansion behavior within MatTabs.

(cherry picked from commit ed45f44)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker docs This issue is related to documentation merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(MatTable): Expandable MatTable rows are expanded when inside a MatTab inside a component
2 participants