Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix broken example due to missing input module import #27637

Merged
merged 1 commit into from
Aug 13, 2023
Merged

docs: fix broken example due to missing input module import #27637

merged 1 commit into from
Aug 13, 2023

Conversation

guiseek
Copy link
Contributor

@guiseek guiseek commented Aug 12, 2023

Error: mat-form-field must contain a MatFormFieldControl.

@angular-robot angular-robot bot added the area: docs Related to the documentation label Aug 12, 2023
crisbeto
crisbeto approved these changes Aug 12, 2023
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto
Copy link
Member

You'll have to add "//src/material/input" to https://github.com/angular/components/blob/main/src/components-examples/material/sidenav/BUILD.bazel#L21 to fix the build.

@guiseek
Copy link
Contributor Author

guiseek commented Aug 12, 2023

You'll have to add "//src/material/input" to https://github.com/angular/components/blob/main/src/components-examples/material/sidenav/BUILD.bazel#L21 to fix the build.

Done. Thank you!

@crisbeto crisbeto self-assigned this Aug 13, 2023
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Aug 13, 2023
@crisbeto crisbeto merged commit 595b3da into angular:main Aug 13, 2023
8 checks passed
crisbeto pushed a commit that referenced this pull request Aug 13, 2023
@guiseek @crisbeto
docs: fix broken example due to missing input module import (#27637)
69652b0 
(cherry picked from commit 595b3da)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guiseek @crisbeto