Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/list): Move unthemable tokens to theme mixin #27607

Merged

Conversation

amysorto
Copy link
Contributor

@amysorto amysorto commented Aug 9, 2023

Though these tokens are not currently affected by the theme, in the future they will be affected by the design system used for theming (M2 or M3)

BREAKING CHANGE:
There are new styles emitted by mat.list-theme that are not emitted by any of: mat.list-color, mat.list-typography, mat.list-density. If you rely on the partial mixins only and don't call mat.list-theme, you can add mat.list-base to get the missing styles.

@angular-robot angular-robot bot added the detected: breaking change PR contains a commit with a breaking change label Aug 9, 2023
@amysorto amysorto added the target: major This PR is targeted for the next major release label Aug 10, 2023
@amysorto amysorto marked this pull request as ready for review August 10, 2023 16:52
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Though these tokens are not currently affected by the theme, in the
future they will be affected by the design system used for theming (M2
or M3)

BREAKING CHANGE:
There are new styles emitted by `mat.list-theme` that are not
emitted by any of: `mat.list-color`, `mat.list-typography`,
`mat.list-density`. If you rely on the partial mixins only and don't
call `mat.list-theme`, you can add `mat.list-base` to get the
missing styles.
@amysorto amysorto force-pushed the unthemable-list-tokens-to-theme-mixin branch from 7d89fa6 to cff69b3 Compare August 14, 2023 16:48
@amysorto amysorto added the action: merge The PR is ready for merge by the caretaker label Aug 14, 2023
@amysorto amysorto merged commit 7c16cc8 into angular:main Aug 14, 2023
13 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker detected: breaking change PR contains a commit with a breaking change target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants