Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/button): Move unthemable icon button tokens to theme mixin #27570

Merged

Conversation

amysorto
Copy link
Contributor

@amysorto amysorto commented Aug 2, 2023

No description provided.

@amysorto amysorto force-pushed the unthemable-icon-tokens-to-theme-mixin branch from 6250bd9 to 7738c47 Compare August 2, 2023 23:44
@amysorto amysorto force-pushed the unthemable-icon-tokens-to-theme-mixin branch from 7738c47 to 536686e Compare October 20, 2023 21:22
@amysorto amysorto added target: minor This PR is targeted for the next minor release area: material/button labels Oct 20, 2023
Though these tokens are not currently affected by the theme, in the
future they will be affected by the design system used for theming (M2
or M3)
@amysorto amysorto force-pushed the unthemable-icon-tokens-to-theme-mixin branch from 536686e to e5b8095 Compare October 20, 2023 21:27
@amysorto amysorto marked this pull request as ready for review October 20, 2023 21:29
@amysorto amysorto removed the request for review from andrewseguin October 23, 2023 12:46
@amysorto amysorto added the action: merge The PR is ready for merge by the caretaker label Oct 23, 2023
@amysorto amysorto merged commit 556eeb1 into angular:main Oct 23, 2023
24 of 26 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: material/button target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants