feat(theme): add the ability to add (even partial) background and foreground to color object#27459
Closed
heXXag0n wants to merge 1 commit intoangular:mainfrom
Closed
feat(theme): add the ability to add (even partial) background and foreground to color object#27459heXXag0n wants to merge 1 commit intoangular:mainfrom
heXXag0n wants to merge 1 commit intoangular:mainfrom
Conversation
…eground to color object While declaring the primary, accent and warn via the color object is easy and straight-forward, the configuration of foreground and background proves rather tedious. This commit adds the ability to declare foreground and background in the color object when defining a theme, even partially, meaning that missing values are taken from the default light or dark theme respectively. Fixes angular#11390, angular#6244
Author
|
Example: $main-theme: mat.define-dark-theme((
color: (
primary: $theme-primary,
accent: $theme-accent,
warn: $theme-warn,
foreground: $mat-dark-theme-foreground,
background: $mat-dark-theme-background,
),
typography: mat.define-typography-config(),
density: 0,
));whereas the background configuration looks i.e. like this $mat-dark-theme-background: (
background: $dark-background,
status-bar: $dark-bg-lighter-20,
app-bar: $dark-bg-lighter-5,
hover: $light-bg-alpha-4,
card: $dark-bg-lighter-5,
dialog: $dark-bg-lighter-5,
tooltip: $dark-bg-lighter-20,
disabled-button: $light-bg-alpha-12,
raised-button: $dark-bg-lighter-5,
focused-button: $light-focused,
selected-button: $dark-bg-lighter-20,
selected-disabled-button: $dark-bg-lighter-30,
disabled-button-toggle: $dark-bg-lighter-10,
unselected-chip: $dark-bg-lighter-20,
disabled-list-option: $dark-bg-lighter-10,
); |
Contributor
|
Thanks for this contribution! We are actually in the works of redoing our whole theming setup to start bringing in Material 3 styles. We agree that it's not easy to customize specific parts of components and we want to make it easier. However, we do not expect to use the current setup, so this PR will already be out of sync with our plans. We appreciate the work |
Author
|
Oh okay, thanks for information and the quick reply :) |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(theme): add the ability to add (even partial) background and foreground to color object
While declaring the primary, accent and warn via the color object is easy and straight-forward, the configuration of foreground and background proves rather tedious. This commit adds the ability to declare foreground and background in the color object when defining a theme, even partially, meaning that missing values are taken from the default light or dark theme respectively.
Fixes #11390, #6244