feat(material-luxon-adapter): add option to set default calendar #27453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add defaultOutputCalendar option to be able to change default calndar through MAT_LUXON_DATE_ADAPTER_OPTIONS
crisbeto
reviewed
Jul 14, 2023
| @@ -71,6 +81,9 @@ export class LuxonDateAdapter extends DateAdapter<LuxonDateTime> { | |||
| this._useUTC = !!options?.useUtc; | |||
| this._firstDayOfWeek = options?.firstDayOfWeek || 0; | |||
| this.setLocale(dateLocale || LuxonDateTime.local().locale); | |||
|
|
|||
| this._defaultOutputCalendar = options?.defaultOutputCalendar || 'gregory'; | |||
| LuxonSettings.defaultOutputCalendar = this._defaultOutputCalendar; | |||
There was a problem hiding this comment.
Doing this will affect uses of Luxon outside of Angular Material which we generally try to avoid. Can we do this only when constructing a date instead?
There was a problem hiding this comment.
Updated the code. Thanks
Update options of luxon-date-adapter to add defaultOutputCalendar to be able to change default calndar through MAT_LUXON_DATE_ADAPTER_OPTIONS
crisbeto
added
action: merge
AnthonyFr75
pushed a commit
to AnthonyFr75/components
that referenced
this pull request
Jul 31, 2023
…ular#27453) * feat(material-luxon-adapter): add option to set default calendar Add defaultOutputCalendar option to be able to change default calndar through MAT_LUXON_DATE_ADAPTER_OPTIONS * feat(material-luxon-adapter): update options to add default calendar Update options of luxon-date-adapter to add defaultOutputCalendar to be able to change default calndar through MAT_LUXON_DATE_ADAPTER_OPTIONS
stephenrca
pushed a commit
to stephenrca/components
that referenced
this pull request
Aug 2, 2023
…ular#27453) * feat(material-luxon-adapter): add option to set default calendar Add defaultOutputCalendar option to be able to change default calndar through MAT_LUXON_DATE_ADAPTER_OPTIONS * feat(material-luxon-adapter): update options to add default calendar Update options of luxon-date-adapter to add defaultOutputCalendar to be able to change default calndar through MAT_LUXON_DATE_ADAPTER_OPTIONS
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add defaultOutputCalendar option to be able to change default calndar through MAT_LUXON_DATE_ADAPTER_OPTIONS