Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/expansion): panel content visible when placed inside a hidden parent #27438

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

crisbeto
Copy link
Member

The expansion panel was setting visibility: visible on the content which meant that it would be visible when placed inside of a parent that is visibility: hidden.

These changes resolve the issue by clear the visibility instead.

Fixes #27436.

…idden parent

The expansion panel was setting `visibility: visible` on the content which meant that it would be visible when placed inside of a parent that is `visibility: hidden`.

These changes resolve the issue by clear the `visibility` instead.

Fixes angular#27436.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jul 12, 2023
@crisbeto crisbeto requested a review from devversion July 12, 2023 07:10
@crisbeto crisbeto self-assigned this Jul 12, 2023
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jul 12, 2023
@crisbeto crisbeto merged commit fd04721 into angular:main Jul 12, 2023
12 checks passed
crisbeto added a commit that referenced this pull request Jul 12, 2023
…idden parent (#27438)

The expansion panel was setting `visibility: visible` on the content which meant that it would be visible when placed inside of a parent that is `visibility: hidden`.

These changes resolve the issue by clear the `visibility` instead.

Fixes #27436.

(cherry picked from commit fd04721)
stephenrca pushed a commit to stephenrca/components that referenced this pull request Aug 2, 2023
…idden parent (angular#27438)

The expansion panel was setting `visibility: visible` on the content which meant that it would be visible when placed inside of a parent that is `visibility: hidden`.

These changes resolve the issue by clear the `visibility` instead.

Fixes angular#27436.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(mat-expansion-panel): Stays visible even though it is within div with style.visibility=hidden
3 participants