Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk/portal): remove ComponentFactoryResolver usages #27427

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

crisbeto
Copy link
Member

We now have all the necessary APIs to allow to remove our usages of the deprecated ComponentFactoryResolver.

Fixes #24334.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jul 10, 2023
@crisbeto crisbeto self-assigned this Jul 10, 2023
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jul 10, 2023
@crisbeto crisbeto force-pushed the 24334/cfr-removal branch 2 times, most recently from 56a3230 to d31b549 Compare July 11, 2023 09:06
@crisbeto
Copy link
Member Author

This one is blocked, because it caused some subtle DI behavior differences in g3 which break some tests.

@JvanderHeide
Copy link

JvanderHeide commented Jan 12, 2024

I'm currently using this in a module federation setup in combination with ngx-translate.
When I leave out the component factory resolver, the component is mounted in the parent project (where the portal outlet is) and as such is missing the translations from my module.

However, when i explicitly add the componentFactoryResolver, my translations are loaded from my child project as it should in this case. ie. the component is rendered as if it was fully in my child project.

image

From how i just read these changes, it would seem that viewContainerRef should be sufficient to achieve the same? Is that correct?

@damianbeles
Copy link

@crisbeto any updates on this one?

@yahya-uddin
Copy link

Any update on this?

@markusahrweileramcon
Copy link

Can you please share the current state?

We now have all the necessary APIs to allow to remove our usages of the deprecated `ComponentFactoryResolver`.

Fixes angular#24334.
@crisbeto crisbeto requested a review from a team as a code owner September 13, 2024 10:42
@crisbeto crisbeto requested review from wagnermaciel and removed request for a team September 13, 2024 10:42
@crisbeto crisbeto added target: major This PR is targeted for the next major release and removed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Sep 13, 2024
@crisbeto crisbeto merged commit 873eb01 into angular:main Sep 14, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(DomPortalOutlet): Alternative constructor (ComponentFactoryResolver is deprecated)
6 participants