Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schematics/card): Migrated to appearance=outlined wich is not the MDC standard #27418

Closed
wants to merge 1 commit into from

Conversation

yatho
Copy link

@yatho yatho commented Jul 6, 2023

The schematics change standard raised to outlined. I have deleted the rules in schematics.

Fixes #27004

… MDC standard

The schematics change standard raised to outlined. I have deleted the rules in schematics.

Fixes angular#27004
@wagnermaciel
Copy link
Contributor

@mmalerba Correct me if I'm wrong here but isn't appearance="outlined" added to keep the card looking as similar to the legacy card as possible?

@devversion devversion removed their request for review August 7, 2023 12:44
@mmalerba
Copy link
Contributor

I'm not actually sure why the schematics add the appearance=outline, maybe a mistake because the legacy card is elevated.

Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yatho yatho closed this Apr 2, 2024
@yatho yatho deleted the fix-schematics-card branch April 2, 2024 19:35
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(schematics): MDC migration: <mat-card> is migrated to appearance=outlined, which is not the MDC standard
3 participants