Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/slider): change slider to use MDC's token API #27375

Merged
merged 1 commit into from
Aug 2, 2023
Merged

fix(material/slider): change slider to use MDC's token API #27375

merged 1 commit into from
Aug 2, 2023

Conversation

amysorto
Copy link
Contributor

No description provided.

@amysorto amysorto requested a review from crisbeto July 18, 2023 20:17
@amysorto amysorto added target: minor This PR is targeted for the next minor release area: material/slider labels Jul 18, 2023
@amysorto amysorto marked this pull request as ready for review July 18, 2023 20:19
crisbeto
crisbeto approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit.

src/material/slider/slider.scss Outdated Show resolved Hide resolved
@amysorto amysorto added the action: merge The PR is ready for merge by the caretaker label Aug 2, 2023
@amysorto amysorto merged commit b13c6aa into angular:main Aug 2, 2023
13 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

@devversion devversion Awaiting requested review from devversion

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: material/slider target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amysorto @crisbeto