build: update rules_sass version to latest #18242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates `rules_sass` to the latest version that contains: bazelbuild/rules_sass@dd0079b. This fixes that errors are reported silently and only shown once the CSS file is served in the browser. It still means that the message might not be printed in the terminal, since there is still bazelbuild/rules_sass#96, but it's better seeing that something failed at compilation time.
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
josephperrott
added
pr: lgtm
action: merge
yifange
pushed a commit
to yifange/components
that referenced
this pull request
Jan 30, 2020
Updates `rules_sass` to the latest version that contains: bazelbuild/rules_sass@dd0079b. This fixes that errors are reported silently and only shown once the CSS file is served in the browser. It still means that the message might not be printed in the terminal, since there is still bazelbuild/rules_sass#96, but it's better seeing that something failed at compilation time.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
rules_sassto the latest version that contains: bazelbuild/rules_sass@dd0079b.This fixes that errors are reported silently and only shown once the CSS file is
served in the browser. It still means that the message is not printed in the terminal
because bazelbuild/rules_sass#96 is not fixed yet.