New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/checkbox): clear name from host node #15368

Closed

crisbeto wants to merge 1 commit into angular:main from crisbeto:checkbox-host-name

Member

crisbeto commented Mar 2, 2019

Currently we forward the name attribute from the host node to the underlying input, however we leave the name on the host node intact. This can throw off functions like document.getElementsByName or the By.name Protractor selector.

crisbeto added the target: patch label

crisbeto assigned jelbourn

crisbeto requested review from devversion, jelbourn and josephperrott as code owners

March 2, 2019 18:01

googlebot added the cla: yes label

josephperrott previously approved these changes

View reviewed changes

Member

josephperrott left a comment

LGTM

josephperrott added pr: lgtm action: merge labels

crisbeto added a commit to crisbeto/material2 that referenced this pull request


          fix(radio): clear names from host nodes

225cbc8

Along the same lines as angular#15368. Clears the `name` from the host node of the radio button and radio group, because they end up being forwarded to the underlying `input` and can cause double results when using something like `getElementsByName`.

crisbeto mentioned this pull request

fix(material/radio): clear names from host nodes #15422

Closed

crisbeto added a commit to crisbeto/material2 that referenced this pull request


          fix(slide-toggle): clear name from host node

171834c

Along the same lines as angular#15422 and angular#15368. Clears the static `name` attribute from the slide toggle's host node in order to prevent both the underlying input and the host from showing up in `document.getElementsByName` or `By.name`.

crisbeto mentioned this pull request

fix(material/slide-toggle): clear name from host node #15505

Merged

crisbeto added a commit to crisbeto/material2 that referenced this pull request


          fix(slide-toggle): clear name from host node

2fbcbd1

Along the same lines as angular#15422 and angular#15368. Clears the static `name` attribute from the slide toggle's host node in order to prevent both the underlying input and the host from showing up in `document.getElementsByName` or `By.name`.

crisbeto added a commit to crisbeto/material2 that referenced this pull request


          fix(button-toggle): clear name from host node

f09df73

Along the same lines as angular#15368. Since we forward the `name` to the underlying native inside a button toggle, otherwise the results from `document.getElementsByName` or Protractor's `By.name` might be thrown off.

crisbeto mentioned this pull request

fix(button-toggle): clear name from host node #15668

Merged

jelbourn added ༼ つ ◕_◕ ༽つ and removed ༼ つ ◕_◕ ༽つ labels

mmalerba added aaa and removed aaa labels

crisbeto added a commit to crisbeto/material2 that referenced this pull request


          fix(slide-toggle): clear name from host node

799d642

Along the same lines as angular#15422 and angular#15368. Clears the static `name` attribute from the slide toggle's host node in order to prevent both the underlying input and the host from showing up in `document.getElementsByName` or `By.name`.

crisbeto added a commit to crisbeto/material2 that referenced this pull request


          fix(button-toggle): clear name from host node

b8735c0

Along the same lines as angular#15368. Since we forward the `name` to the underlying native inside a button toggle, otherwise the results from `document.getElementsByName` or Protractor's `By.name` might be thrown off.

jelbourn pushed a commit that referenced this pull request


          fix(button-toggle): clear name from host node (#15668)

623cd06

Along the same lines as #15368. Since we forward the `name` to the underlying native inside a button toggle, otherwise the results from `document.getElementsByName` or Protractor's `By.name` might be thrown off.

crisbeto force-pushed the checkbox-host-name branch from faab92a to b14f79b Compare

May 30, 2019 06:25

RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request


          fix(button-toggle): clear name from host node (angular#15668)

9566cf4

Along the same lines as angular#15368. Since we forward the `name` to the underlying native inside a button toggle, otherwise the results from `document.getElementsByName` or Protractor's `By.name` might be thrown off.

crisbeto added a commit to crisbeto/material2 that referenced this pull request


          fix(radio): clear names from host nodes

a6b2616

Along the same lines as angular#15368. Clears the `name` from the host node of the radio button and radio group, because they end up being forwarded to the underlying `input` and can cause double results when using something like `getElementsByName`.

crisbeto added a commit to crisbeto/material2 that referenced this pull request


          fix(slide-toggle): clear name from host node

a7504de

Along the same lines as angular#15422 and angular#15368. Clears the static `name` attribute from the slide toggle's host node in order to prevent both the underlying input and the host from showing up in `document.getElementsByName` or `By.name`.

crisbeto force-pushed the checkbox-host-name branch from b14f79b to 99b0f9b Compare

September 15, 2019 16:59

crisbeto added a commit to crisbeto/material2 that referenced this pull request


          fix(radio): clear names from host nodes

5c2c31b

Along the same lines as angular#15368. Clears the `name` from the host node of the radio button and radio group, because they end up being forwarded to the underlying `input` and can cause double results when using something like `getElementsByName`.

crisbeto added a commit to crisbeto/material2 that referenced this pull request


          fix(slide-toggle): clear name from host node

23158d8

Along the same lines as angular#15422 and angular#15368. Clears the static `name` attribute from the slide toggle's host node in order to prevent both the underlying input and the host from showing up in `document.getElementsByName` or `By.name`.

crisbeto added a commit to crisbeto/material2 that referenced this pull request


          fix(radio): clear names from host nodes

d298469

Along the same lines as angular#15368. Clears the `name` from the host node of the radio button and radio group, because they end up being forwarded to the underlying `input` and can cause double results when using something like `getElementsByName`.

crisbeto added a commit to crisbeto/material2 that referenced this pull request


          fix(radio): clear names from host nodes

f7e96d2

Along the same lines as angular#15368. Clears the `name` from the host node of the radio button and radio group, because they end up being forwarded to the underlying `input` and can cause double results when using something like `getElementsByName`.

mmalerba removed the lgtm label

crisbeto added a commit to crisbeto/material2 that referenced this pull request


          fix(material/slide-toggle): clear name from host node

e280988

Along the same lines as angular#15422 and angular#15368. Clears the static `name` attribute from the slide
toggle's host node in order to prevent both the underlying input and the host from showing
up in `document.getElementsByName` or `By.name`.

devversion removed their request for review

August 18, 2021 12:55

andrewseguin added needs rebase and removed cla: yes labels

crisbeto added a commit to crisbeto/material2 that referenced this pull request


          fix(material/slide-toggle): clear name from host node

3bed139

Along the same lines as angular#15422 and angular#15368. Clears the static `name` attribute from the slide
toggle's host node in order to prevent both the underlying input and the host from showing
up in `document.getElementsByName` or `By.name`.

crisbeto added a commit to crisbeto/material2 that referenced this pull request


          fix(material/radio): clear names from host nodes

bbbc038

Along the same lines as angular#15368. Clears the `name` from the host node of the radio button and radio group, because they end up being forwarded to the underlying `input` and can cause double results when using something like `getElementsByName`.

crisbeto added a commit that referenced this pull request


          fix(material/slide-toggle): clear name from host node (#15505)

911d6b7

Along the same lines as #15422 and #15368. Clears the static `name` attribute from the slide
toggle's host node in order to prevent both the underlying input and the host from showing
up in `document.getElementsByName` or `By.name`.

(cherry picked from commit 5db1df0)

crisbeto added a commit that referenced this pull request


          fix(material/slide-toggle): clear name from host node (#15505)

5db1df0

Along the same lines as #15422 and #15368. Clears the static `name` attribute from the slide
toggle's host node in order to prevent both the underlying input and the host from showing
up in `document.getElementsByName` or `By.name`.

andrewseguin unassigned jelbourn

forsti0506 pushed a commit to forsti0506/components that referenced this pull request


          fix(material/slide-toggle): clear name from host node (angular#15505)

cf84f1d

Along the same lines as angular#15422 and angular#15368. Clears the static `name` attribute from the slide
toggle's host node in order to prevent both the underlying input and the host from showing
up in `document.getElementsByName` or `By.name`.

andrewseguin assigned crisbeto

andrewseguin dismissed josephperrott’s stale review via

99b0f9b

May 2, 2022 20:32

crisbeto added a commit to crisbeto/material2 that referenced this pull request


          fix(material/radio): clear names from host nodes

fe0f0e8

Along the same lines as angular#15368. Clears the `name` from the host node of the radio button and radio group, because they end up being forwarded to the underlying `input` and can cause double results when using something like `getElementsByName`.

josephperrott added action: cleanup and removed needs rebase labels

andrewseguin unassigned crisbeto


          fix(material/checkbox): clear name from host node

ec1c6c4

Currently we forward the name attribute from the host node to the underlying input, however we leave the name on the host node intact. This can throw off functions like `document.getElementsByName` or the `By.name` Protractor selector.

crisbeto force-pushed the checkbox-host-name branch from 99b0f9b to ec1c6c4 Compare

February 28, 2024 08:18

crisbeto requested a review from mmalerba as a code owner

February 28, 2024 08:18

crisbeto changed the title ~~fix(checkbox): clear name from host node~~ fix(material/checkbox): clear name from host node

crisbeto removed the action: cleanup label

Member Author

crisbeto commented Feb 28, 2024

Looks like this is really breaking internally. I'll close it for now since we haven't gotten any issue reports about it.

crisbeto closed this

angular-automatic-lock-bot bot commented Mar 30, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

angular-automatic-lock-bot bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge target: patch