test: fix overzealous calls to markForCheck from #29083 (#29131)

(cherry picked from commit 32c5308)
angular · May 29, 2024 · 6281fe6 · 6281fe6
1 parent 3d13876
commit 6281fe6
Show file tree

Hide file tree

Showing 11 changed files with 208 additions and 817 deletions.
diff --git a/src/cdk/a11y/live-announcer/live-announcer.spec.ts b/src/cdk/a11y/live-announcer/live-announcer.spec.ts
@@ -178,7 +178,6 @@ describe('LiveAnnouncer', () => {
       const overlayRef = overlay.create();
       const componentRef = overlayRef.attach(portal);
       const modal = componentRef.location.nativeElement;
-      fixture.changeDetectorRef.markForCheck();
       fixture.detectChanges();
 
       expect(ariaLiveElement.id).toBeTruthy();
@@ -199,7 +198,6 @@ describe('LiveAnnouncer', () => {
       const overlayRef = overlay.create();
       const componentRef = overlayRef.attach(portal);
       const modal = componentRef.location.nativeElement;
-      fixture.changeDetectorRef.markForCheck();
       fixture.detectChanges();
 
       componentRef.instance.ariaOwns = 'foo bar';
@@ -320,7 +318,6 @@ describe('CdkAriaLive', () => {
       announcer = la;
       announcerSpy = spyOn(la, 'announce').and.callThrough();
       fixture = TestBed.createComponent(DivWithCdkAriaLive);
-      fixture.changeDetectorRef.markForCheck();
       fixture.detectChanges();
       flush();
     }),
@@ -375,7 +372,6 @@ describe('CdkAriaLive', () => {
 
     expect(announcer.announce).toHaveBeenCalledTimes(1);
 
-    fixture.changeDetectorRef.markForCheck();
     fixture.detectChanges();
     invokeMutationCallbacks();
     flush();

diff --git a/src/cdk/clipboard/copy-to-clipboard.spec.ts b/src/cdk/clipboard/copy-to-clipboard.spec.ts
@@ -78,7 +78,6 @@ describe('CdkCopyToClipboard', () => {
     fixture.detectChanges();
 
     fixture.nativeElement.querySelector('button')!.click();
-    fixture.changeDetectorRef.markForCheck();
     fixture.detectChanges();
     tick(3);
 
@@ -102,7 +101,6 @@ describe('CdkCopyToClipboard', () => {
     fixture.detectChanges();
 
     fixture.nativeElement.querySelector('button')!.click();
-    fixture.changeDetectorRef.markForCheck();
     fixture.detectChanges();
     tick(3);
 
@@ -122,11 +120,9 @@ describe('CdkCopyToClipboard', () => {
     fixture.detectChanges();
 
     spyOn(clipboard, 'beginCopy').and.returnValue(fakeCopy);
-    fixture.changeDetectorRef.markForCheck();
     fixture.detectChanges();
 
     fixture.nativeElement.querySelector('button')!.click();
-    fixture.changeDetectorRef.markForCheck();
     fixture.detectChanges();
     tick(1);