Skip to content
This repository has been archived by the owner on Sep 8, 2020. It is now read-only.

make CI build faster #252

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

make CI build faster #252

wants to merge 1 commit into from

Conversation

PeterDaveHello
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 33b1f5b on PeterDaveHello:patch-1 into d21f532 on angular-ui:master.

@thgreasi
Copy link
Contributor

With the current size of the repo, I didn't see any gains comparing this PR's build time and for example the svg PR??

@PeterDaveHello
Copy link
Contributor Author

Because the deviation range is very big, but it can still help, just like we don't need the whole repo to CI build, do use git shallow clone, the default value of depth is 50 on travis CI, but usually we don't need so many revisions to build, a lower number can help to save the bandwidth and time.

@thgreasi
Copy link
Contributor

The merging of v0.13.x-dev branch into master contained more than 20 commits, would that be a problem with this PR?
Also, while searching Github I found that some repos have reverted their explicit git setting.

@PeterDaveHello
Copy link
Contributor Author

I think that won't be a problem.

@thgreasi
Copy link
Contributor

I will be honest... I'm afraid enough to not merge this.
I appreciate your commit and plan to rebase it after each major release of ui-sortable. At the point that the CI build gets faster, I will reopen and merge it.

@PeterDaveHello
Copy link
Contributor Author

No problem.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants