Issue 1820

[zajacmp3]

In response to issue raised: #1820

I have added a new html tag called object-unique-key.
This tag allows us to define based on what we define if an object is or is not unique.

[user378230]

Shouldn't we actually just be using the value specified in track by?

It appears we are duplicating functionality with this.

[zajacmp3]

I'll investigate that and get back to you with an answer by the end of the weekend.

[zajacmp3]

@user378230

I failed to reproduce my solution with track by so personally I would opt to say that we are not duplicating functionality. While doing code analysis when using multiple select and tagging there is no other logic that compare objects. I modified the only one in a generic way.

During my investigation I found out that:
track by is used in directive used to show choices/match items and to support ng-repeat directive
<ui-select-choices repeat="address in ctrl.addresses track by $index"
http://angular-ui.github.io/ui-select/demo-basic.html

* Original discussion about parsing "repeat" attribute instead of fully relying on ng-repeat:
* https://github.com/angular-ui/ui-select/commit/5dd63ad#commitcomment-5504697

uisRepeatParserService.js:7-8

  self.getGroupNgRepeatExpression = function() {
    return '$group in $select.groups track by $group.name';
  };

So track by does not seems to do the trick at the minute.

But maybe you wanted to ask could we re use track by argument in ui select directive as it seems that we might not want to add yet another argument to directive?

[UsamaKhalil-KSO]

awsome, we need this.