This repository was archived by the owner on Oct 2, 2019. It is now read-only.
Fix baseline when direction-up positioning is used #1123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdjackson
force-pushed
the
fix_up_direction_baseline
branch
from
34b3162 to
571bb46
Compare
cdjackson
force-pushed
the
fix_up_direction_baseline
branch
from
571bb46 to
3d54802
Compare
|
👍 |
|
+1. |
|
Works for me |
|
Works for me too |
|
Bug is fixed in current version of angular-ui-select (0.13.1) |
|
Is this already fixed? This looks like an elegant fix otherwise. |
|
Any movement on this ? |
|
+1 |
|
This issue is still happening in the latest version. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When direction-up positioning is used, there was an issue where the select box would stay aligned at the top, and the height would reduce, meaning the bottom moved away from the top of the search box (see #973).
This PR removes the hardcoded top added in the code, and instead uses CSS positioning to position based on the absolute position at the bottom of the select.