Replace Jython with JPype #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twizmwazin
force-pushed
the
refactor/jpype
branch
from
eee78de
to
4d9a50e
Compare
twizmwazin
force-pushed
the
refactor/jpype
branch
from
4d9a50e
to
c1103b4
Compare
|
So this now works, angr tests pass locally, no changes! However there seem to be some stability issues on the JPype end of things. It seems to segfault frequently, based on timing alone I suspect that it is something to do with badly deallocating things. |
twizmwazin
force-pushed
the
refactor/jpype
branch
3 times, most recently
from
a3123a8
to
98d5b92
Compare
twizmwazin
force-pushed
the
refactor/jpype
branch
2 times, most recently
from
c86fba3
to
35d4b64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the Jython and IPC layers of Pysoot with JPype. This fixes wheel support, windows support, Mac support, non-x86 support, removes Jython and Python 2 code. I've also upgraded the IR itself to use dataclasses (with types!) which I found made things easier to debug. Actual interface changes should be minimal, angr's test_java.py passes locally without any changes.