Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin refactor #1026

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Plugin refactor #1026

wants to merge 3 commits into from

Conversation

twizmwazin
Copy link
Member

@twizmwazin twizmwazin commented Jun 20, 2023

This is the first step of my plugin refactor. I have a roughly three step plan:

  1. Improve and document the metadata specification to accommodate immediate needs of step 2
  2. Implement loading of plugins from a user plugin directory, including site-packages
  3. Add a basic UI that allows selecting the order in which plugins are initialized to allow users to sort-of handle dependency issues if they arise, and install new plugins through the UI

Current status: Step 1 is mostly done unless I hit a snag in the future. Schema tests pass.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2023

Test Results

8 tests   - 11   8 ✔️  - 11   0s ⏱️ - 1m 28s
3 suites  -   7   0 💤 ±  0 
3 files    -   7   0 ±  0 

Results for commit 2e5eb02. ± Comparison against base commit 4f1e1bc.

This pull request removes 14 and adds 3 tests. Note that renamed tests count towards both.
test_qaddress_input.TestQaddressInput ‑ test_address_conversion
test_qaddress_input.TestQaddressInput ‑ test_function_name
test_rename_functions.TestRenameFunctions ‑ test_rename_a_callee_in_pseudocode_view
test_rename_functions.TestRenameFunctions ‑ test_rename_a_function_in_disasm_and_pseudocode_views
test_rename_variables.TestRenameVariables ‑ test_rename_a_global_variable_in_pseudocode_view
test_rename_variables.TestRenameVariables ‑ test_rename_a_local_variable_in_pseudocode_view
test_tagged_interval_map.TaggedIntervalMapTests ‑ test_empty_iteration
test_tagged_interval_map.TaggedIntervalMapTests ‑ test_insertion_already_covered
test_tagged_interval_map.TaggedIntervalMapTests ‑ test_merge_left
test_tagged_interval_map.TaggedIntervalMapTests ‑ test_merge_middle
…
test_plugin_desciption_loading.TestPluginDescriptionLoading ‑ test_minimal_package
test_plugin_desciption_loading.TestPluginDescriptionLoading ‑ test_minimal_plugin
test_plugin_desciption_loading.TestPluginDescriptionLoading ‑ test_no_plugins

♻️ This comment has been updated with latest results.

@twizmwazin twizmwazin force-pushed the plugin-refactor branch 2 times, most recently from b600bce to b28cf82 Compare July 13, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant