Rename AUDIO_DTS_X to AUDIO_DTS_UHD_P2#3138
Merged
copybara-service[bot] merged 3 commits intoandroidx:mainfrom Mar 27, 2026
Merged
Rename AUDIO_DTS_X to AUDIO_DTS_UHD_P2#3138copybara-service[bot] merged 3 commits intoandroidx:mainfrom
copybara-service[bot] merged 3 commits intoandroidx:mainfrom
Conversation
* The AudioFormat constant is named ENCODING_DTS_UHD_P2, and the internal platform mime type constant too is named MEDIA_MIMETYPE_AUDIO_DTS_UHD_P2. It's a correct and clear way to refer to this format. * DTS:X is a marketing name that can be misleading because DTS:X is a proprietary extension to other DTS formats, however DTS:X supports both DTS-HD based and DTS-UHD based formats. Equating DTS-UHD with DTS:X is bound to cause confusion when DTS-HD based DTS:X is encountered. Issue: androidx#2487
Collaborator
|
I'm going to send this for internal review now. You may see some more commits being added as I make changes in response to review feedback. Please refrain from pushing any more substantive changes as it will complicate the internal review - thanks! |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #2487