expand format support for audio processors used by DefaultAudioSink #2259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ivanbuper Could you take a look at this extension? |
|
@ivanbuper ping since it has been a month, any chance you could take a look at this PR? |
|
@nift4 Apologies for the delay. I was OOO for a while and currently solving some high-priority bugs. This PR is on my TODO list and I'll try to take a look very soon. |
ivanbuper
reviewed
May 9, 2025
libraries/exoplayer/src/main/java/androidx/media3/exoplayer/audio/DefaultAudioSink.java
Outdated
Show resolved
Hide resolved
|
I'm going to send this for internal review now. You may see some more commits being added as I make changes in response to review feedback (e.g. formatting). Please refrain from pushing any more substantive changes as it will complicate the internal review - thanks! |
ivanbuper
added a commit
to nift4/media
that referenced
this pull request
May 9, 2025
ivanbuper
added a commit
to nift4/media
that referenced
this pull request
May 15, 2025
ivanbuper
added a commit
to nift4/media
that referenced
this pull request
May 15, 2025
This change is in preparation of github.com/androidx/pull/2259.
ivanbuper
added a commit
to nift4/media
that referenced
this pull request
May 15, 2025
This change is in preparation of github.com/androidx/pull/2259.
ivanbuper
force-pushed
the
audiofmtproc
branch
2 times, most recently
from
15ec015 to
614d830
Compare
ivanbuper
added a commit
to nift4/media
that referenced
this pull request
May 15, 2025
This change is in preparation of github.com/androidx/pull/2259.
ivanbuper
added a commit
to nift4/media
that referenced
this pull request
May 16, 2025
This change is in preparation of github.com/androidx/pull/2259.
ivanbuper
added a commit
to nift4/media
that referenced
this pull request
May 16, 2025
ivanbuper
added a commit
to nift4/media
that referenced
this pull request
May 16, 2025
This change is in preparation of github.com/androidx/pull/2259.
ivanbuper
added a commit
to nift4/media
that referenced
this pull request
May 16, 2025
ivanbuper
added a commit
to nift4/media
that referenced
this pull request
May 16, 2025
This change is in preparation of github.com/androidx/pull/2259.
This allows future extensions such as direct 24 bit / 32 bit (int) playback in DefaultAudioSink, and is a step towards Issue: androidx#1931 Run audio processors possibly discarding data first to avoid wasting CPU on data that'll be discarded anyway.
This change is in preparation of github.com/androidx/pull/2259.
|
Thanks :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows future extensions such as direct 24 bit / 32 bit (int) playback in DefaultAudioSink, and is a step towards Issue: #1931
Run audio processors possibly discarding data first to avoid wasting CPU on data that'll be discarded anyway.