DrmSession Caching Proposal #2049
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `DefaultDrmSessionManager` releases all keep-alive DrmSessions after the `MediaSource` is released, as such the only way to preserve keep-alive sessions from one `MediaItem` playback to the next is to use `Playlist`'s. `Playlist' is not practical for a large live channel set for a couple of reasons: 1. Keeping the `MediaSource` active consumes considerable memory 2. Polling of the MPD/HLS Playlist continues for all `MediaItems` that have ever played in the playlist. This change is conceptually quite simple: 1. Preserve the active list of cached `DrmSession` when `DrmSessionManager.release()` called 2. Add a method that can be used on `Activity.onStop()` to release the cached `DrmSession`'s This new behavior is guarded by a setting that defaults to the old behavior. This commit also includes a fix to remove `preacquiredSessionReferences` when their associated session is fully released (to avoid the logged error message for `referenceCount` < 0)
Adds basic DrmSession logging for
1. `DrmSession` acquire is a cache hit
2. If resource issues require flushing the `DrmSession` cache
3. When sessions are expired from the cache
|
This is also a possible solution for issue #394 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of commits implements extending the functionality of the
DefaultDrmSessionManagersetSessionKeepaliveMs()to allow keeping openMediaDrmsessions beyond the live time of any oneMediaSourceOur fork of ExoPlayer is using this implementation to support a large live channel lineup while reducing the tune load on the DRM License Server significantly (we see hit ratios over 50% on AmLogic hardware).
The related issue Is #2048
One improvement would be to add a "player release listener" API to ExoPlayer to allow automatically calling the
releaseAllSessions()method onDefaultDrmSessionManagerrather than requiring the application to do this manually.