Update dependencies and add update deps workflow #948
Conversation
Change-Id: Ic667c05d37eee5738bc24b2a18b2182093abb5c0
Change-Id: Ia037b710c933db39aca71db19d5bcfdf476bf0e9
.github/ci-gradle.properties
Outdated
| @@ -0,0 +1,26 @@ | |||
| # | |||
| # Copyright 2020 The Android Open Source Project | |||
There was a problem hiding this comment.
I mean, it still feels like 2020 but supposedly it's 2024 these days
buildscripts/init.gradle.kts
Outdated
| @@ -0,0 +1,72 @@ | |||
| /* | |||
| * Copyright 2022 The Android Open Source Project | |||
| @@ -26,3 +26,21 @@ versionCatalogUpdate { | |||
| keepUnusedPlugins.set(true) | |||
| } | |||
| } | |||
|
|
|||
| def isNonStable = { String version -> | |||
| def stableKeyword = ['RELEASE', 'FINAL', 'GA'].any { it -> version.toUpperCase().contains(it) } | |||
There was a problem hiding this comment.
Where do these (potentially) show up? Is it reading something from maven? Otherwise, I'd think none of our versions would match since the stable releases are things like 1.2.3.
There was a problem hiding this comment.
Oh good call—we don't need this line. This was a copy from https://github.com/android/compose-samples/blob/main/JetNews/buildscripts/toml-updater-config.gradle#L30
gradle/libs.versions.toml
Outdated
| okhttpLogging = "4.10.0" | ||
| pagingCompose = "1.0.0-alpha19" | ||
| profileInstaller = "1.2.0" | ||
| minSdk = "28" |
There was a problem hiding this comment.
This is a pretty big jump; intentional?
There was a problem hiding this comment.
I think I bumped this while debugging, but it doesn't have to be 28. Will revert.
gradle/libs.versions.toml
Outdated
| @@ -93,11 +96,11 @@ androidx-paging-compose = { module = "androidx.paging:paging-compose", version.r | |||
| androidx-profileinstaller = { module = "androidx.profileinstaller:profileinstaller", version.ref = "profileInstaller" } | |||
| androidx-room-compiler = { module = "androidx.room:room-compiler", version.ref = "room" } | |||
| androidx-room-ktx = { module = "androidx.room:room-ktx", version.ref = "room" } | |||
| androidx-room-runtime = { module = "androidx.room:room-runtime", version.ref = "room" } | |||
| androidx-room-runtime = "androidx.room:room-runtime:2.5.2" | |||
There was a problem hiding this comment.
Why does this have a specific version instead of the room value above (2.6.1 now)?
There was a problem hiding this comment.
The version-catalog-update-plugin decided to update this and it's unclear why 🤔 However, this dependency is not used by the project so we can remove it altogether.
Change-Id: I4c327c615af09020f07cc9efcae98e0195c820e7
|
Thanks! Will merge this one in as I'd like to update dependencies since that fixes some issues such as previews not working (regression introduced in an alpha version of material3). I'll create a separate PR if anyone else on the team finds anything |
Changes: