Migrate remaining Compose side-effects snippets#832
Conversation
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request completes the migration of several Compose side-effects code snippets from the Android Developer documentation into the project's snippet collection. The changes introduce practical examples for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request migrates two new code snippets for the Compose side-effects documentation: SnapshotFlowExample and RestartingEffectsSnippet. My review focuses on improving the clarity and correctness of these new snippets. I've suggested a stylistic improvement to make the Flow chain more idiomatic in SnapshotFlowExample, and corrected a misleading comment in RestartingEffectsSnippet to avoid confusion for developers reading the documentation.
| snapshotFlow { listState.firstVisibleItemIndex } | ||
| .map { index -> index > 0 } | ||
| .distinctUntilChanged() | ||
| .filter { it == true } |
| onStart: () -> Unit, // Send the 'started' analytics event | ||
| onStop: () -> Unit // Send the 'stopped' analytics event | ||
| ) { | ||
| // These values never change in Composition |
There was a problem hiding this comment.
This comment is misleading. The values held by currentOnStart and currentOnStop are updated on every recomposition, which is the purpose of rememberUpdatedState. The benefit is that using them inside an effect does not cause the effect to restart. A more accurate comment, like the one used in the other HomeScreen example in this file, would be clearer.
| // These values never change in Composition | |
| // Safely update the current lambdas when a new one is provided |
5ea4378 to
9766f96
Compare
Code snippets are for:
Snippets not migrated: