Fix grammar in search empty-state copy ("explorer" -> "explore")#2129
Fix grammar in search empty-state copy ("explorer" -> "explore")#2129Amir-yazdanmanesh wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request fixes a typo in the feature_search_api_try_another_search string resource, changing "explorer" to "explore". The reviewer pointed out that the string resource still contains a trailing space, which leads to a double space in the UI because the calling code already appends a space. A suggestion was made to remove the trailing space.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| <string name="feature_search_api_result_not_found">Sorry, there is no content found for your search \"%1$s\"</string> | ||
| <string name="feature_search_api_not_ready">Sorry, we are still processing the search index. Please come back later</string> | ||
| <string name="feature_search_api_try_another_search">Try another search or explorer </string> | ||
| <string name="feature_search_api_try_another_search">Try another search or explore </string> |
There was a problem hiding this comment.
The string resource feature_search_api_try_another_search contains a trailing space. However, in SearchScreen.kt (line 233), an explicit space is already appended:
append(stringResource(id = searchR.string.feature_search_api_try_another_search))
append(" ")This results in a double space in the rendered UI (i.e., Try another search or explore Interests). Removing the trailing space from the string resource resolves this issue and keeps the resource clean.
| <string name="feature_search_api_try_another_search">Try another search or explore </string> | |
| <string name="feature_search_api_try_another_search">Try another search or explore</string> |
What I've done
Fixes #2127
The Search screen's empty-results message contained a grammar error. The
feature_search_api_try_another_searchstring used "explorer" (a noun) where theverb "explore" was intended. The sentence is assembled in
EmptySearchResultBody(
SearchScreen.kt) as:This PR corrects it to:
Change
A single string-value edit in
feature/search/api/src/main/res/values/strings.xml: