-
Notifications
You must be signed in to change notification settings - Fork 103
Use matchPackageNames with ** #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @mlykotom, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request simplifies the Renovate configuration by consolidating dependency grouping rules for Kotlin, KSP, and SKIE into a single rule using matchPackageNames
with glob patterns. This cleans up the configuration file and streamlines how these related dependencies are handled for updates.
Highlights
- Renovate Configuration: Refactored the
packageRules
section inrenovate.json
to usematchPackageNames
with glob patterns (**
). - Dependency Grouping: Consolidated the rules for
org.jetbrains.kotlin
,com.google.devtools.ksp
, andco.touchlab.skie
dependencies into a single group named "Kotlin Dependencies" using the new glob pattern approach. - SKIE Updates: Removed the specific rule for
co.touchlab.skie:co.touchlab.skie.gradle.plugin
that previously hadprerelease: true
set.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the Renovate configuration to consolidate package rules for Kotlin, KSP, and SKIE dependencies, using matchPackageNames
with glob patterns (**
). This simplifies the overall structure of the packageRules
.
My primary feedback concerns the prerelease: true
setting. This setting was previously active specifically for SKIE updates but is not present in the new consolidated rule. If prereleases are still desired for SKIE (or potentially for all dependencies in this group), this setting should be reinstated in the updated rule. A detailed explanation and a code suggestion are provided in the line-specific comment.
"matchPackageNames": [ | ||
"co.touchlab.skie:co.touchlab.skie.gradle.plugin" | ||
], | ||
"groupName": "SKIE Update Only", | ||
"prerelease": true | ||
"org.jetbrains.kotlin**", | ||
"co.touchlab.skie**", | ||
"com.google.devtools.ksp**" | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This rule consolidates SKIE with other Kotlin dependencies. The previous, separate rule for SKIE (co.touchlab.skie:co.touchlab.skie.gradle.plugin
) included "prerelease": true
. This setting is now absent for SKIE (and the other dependencies) in this combined rule.
If SKIE updates (or if all dependencies in this group) should indeed include prereleases, please consider adding "prerelease": true
to this rule, as shown in the suggestion.
If prerelease: true
is only required for SKIE and not for org.jetbrains.kotlin
or com.google.devtools.ksp
, then SKIE might need to remain in a separate packageRules
entry to maintain that specific configuration, or this rule would need to be split.
"matchPackageNames": [
"org.jetbrains.kotlin**",
"co.touchlab.skie**",
"com.google.devtools.ksp**"
],
"prerelease": true
No description provided.