Skip to content

Add Vulkan dEQP level logging to TrivialKart Unreal sample#117

Open
jsyjbaba wants to merge 3 commits into
mainfrom
feature/vulkan-deqp-log
Open

Add Vulkan dEQP level logging to TrivialKart Unreal sample#117
jsyjbaba wants to merge 3 commits into
mainfrom
feature/vulkan-deqp-log

Conversation

@jsyjbaba

Copy link
Copy Markdown
Contributor

Summary

Adds Vulkan dEQP level diagnostic logging to the TrivialKart Unreal sample.

Key Changes

  • Vulkan dEQP Logging: Checks target dEQP support, converts the level to a YYYY-MM-DD format via bitwise operations, and prints it to Logcat (UE_RHI_Selector).
  • Parser Safety: Used standard XML entities instead of CDATA blocks within the UPL script.

Modified Files

  • Source/TrivialKart_Unreal/DEQP_UPL.xml
  • Source/TrivialKart_Unreal/TrivialKart_Unreal.Build.cs

@jsyjbaba jsyjbaba requested review from RKS13D and natetrost June 12, 2026 07:15

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new XML configuration file (DEQP_UPL.xml) to check and log the Vulkan dEQP level on Android devices, and registers it as an Android plugin in TrivialKart_Unreal.Build.cs. The reviewer provided constructive feedback on both files: for DEQP_UPL.xml, they recommended fixing the flat indentation, specifying java.util.Locale.US in String.format to prevent locale-specific formatting issues, and simplifying the feature name comparison; for TrivialKart_Unreal.Build.cs, they suggested using tabs instead of spaces for indentation consistency and renaming UPlPath to uplPath for better casing consistency.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@RKS13D RKS13D left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natetrost

Copy link
Copy Markdown
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants