Add Vulkan dEQP level logging to TrivialKart Unreal sample#117
Add Vulkan dEQP level logging to TrivialKart Unreal sample#117jsyjbaba wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new XML configuration file (DEQP_UPL.xml) to check and log the Vulkan dEQP level on Android devices, and registers it as an Android plugin in TrivialKart_Unreal.Build.cs. The reviewer provided constructive feedback on both files: for DEQP_UPL.xml, they recommended fixing the flat indentation, specifying java.util.Locale.US in String.format to prevent locale-specific formatting issues, and simplifying the feature name comparison; for TrivialKart_Unreal.Build.cs, they suggested using tabs instead of spaces for indentation consistency and renaming UPlPath to uplPath for better casing consistency.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
LGTM |
Summary
Adds Vulkan dEQP level diagnostic logging to the TrivialKart Unreal sample.
Key Changes
YYYY-MM-DDformat via bitwise operations, and prints it to Logcat (UE_RHI_Selector).Modified Files
Source/TrivialKart_Unreal/DEQP_UPL.xmlSource/TrivialKart_Unreal/TrivialKart_Unreal.Build.cs