Removing toolchain

[riggaroo]

No description provided.

[javadude]

A few general notes:

• jvmToolchain acts as a default for sourceCompatibility, targetCompatibility, and jvmTarget. If we used jvmToolchain, the others aren't needed. (Which is one reason I liked jvmToolchain - one place to specify)

• If we don't have jvmToolchain or jvmTarget, Kotlin defaults to target 1.8. So when jvmToolchain is removed, jvmTarget must be added if not there. (Some scripts had already it)

• Some files didn't have jvmToolchain and it looks like you accidentally removed jvmTarget

• A nit - one script uses

  jvmTarget = JavaVersion.VERSION_17.majorVersion
  

  I'd just change that to "17"

[tunjid]

@javadude 👋🏿 👋🏿

Just a few questions about your comment above as II'm trying to resolve a compile error I have that I typically fix by toggling things till they work:

Inconsistent JVM-target compatibility detected for tasks 'compileJava' (17) and 'compileKotlin' (21)

How do I ensure both of java and kotlin are in sync?

[javadude]

@javadude 👋🏿 👋🏿

Just a few questions about your comment above as II'm trying to resolve a compile error I have that I typically fix by toggling things till they work:

Inconsistent JVM-target compatibility detected for tasks 'compileJava' (17) and 'compileKotlin' (21)

How do I ensure both of java and kotlin are in sync?

does jvmTarget and targetCompatibility match?

kotlinOptions {
    jvmTarget = "17"
}

compileOptions {
    targetCompatibility = JavaVersion.VERSION_17
}

The nice thing about toolchain is that it provides a single-place default for jvmTarget, sourceCompatibility, and targetCompatibility, as well as auto-locate or auto-download the specified JDK.

The problem with toolchain is that if you don't have the build configured to auto-download (using something like the foojay resolver), you must have exactly the specified JDK installed on your machine to build it...

[javadude]

LGTM