Skip to content

Conversation

@casper-jr
Copy link
Contributor

Hi, Thanks for a new sample application with Ink API!

I found a few typos in strings.xml where some <string> tags had trailing quotation marks outside the closing tag.

This PR removes the extra quotes and a typo to fix the XML formatting.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @casper-jr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses minor but important clean-up in the strings.xml file. It focuses on correcting XML formatting issues by removing extraneous quotation marks that were incorrectly placed outside closing string tags, and also fixes a small typo in one of the string resources. These changes improve the overall correctness and consistency of the application's string definitions.

Highlights

  • XML Formatting Correction: Removed invalid trailing quotation marks from several <string> tags in strings.xml to ensure proper XML formatting.
  • Typo Fix: Corrected a minor typo in the 'unfavorite' string resource, changing 'Remove fom favorite' to 'Remove from favorite'.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes several issues in strings.xml. You've removed extraneous quotation marks that were causing XML validation errors and also corrected a typo in a string resource. These changes are accurate and improve the overall quality of the code. Great work!

Copy link
Contributor

@cka-dev cka-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching these.
lgtm

@cka-dev cka-dev merged commit 444a06e into android:main Dec 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants