Fix build errors due to library and tool updates

[HakimNB]

-. Minimal changes to maintain compatibility with Android Studio 4.x

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello @HakimNB, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses build errors by performing essential updates to the project's dependencies and configurations. It modernizes the Android build environment by upgrading SDK versions, migrating to the latest Play Asset Delivery library via Maven, and adjusting native code to reflect API changes, ensuring compatibility with Android Studio 4.x.

Highlights

• Dependency and SDK Updates: The compileSdkVersion has been updated to 34 and minSdkVersion to 21 in the Teapot sample's build.gradle file. Additionally, the Android Gradle Plugin was upgraded from 4.0.0-beta03 to 4.0.2.
• Play Asset Delivery Library Migration: The project now uses the official Maven dependencies for Play Asset Delivery (com.google.android.play:asset-delivery:2.3.0 and asset-delivery-ktx:2.3.0), replacing the previously used local playcore.aar file.
• Native API Renaming: Native C++ calls within PlayAssetDeliveryUtil.cpp have been updated, specifically renaming AssetPackManager_showCellularDataConfirmation to AssetPackManager_showConfirmationDialog to align with API changes.
• Gradle Configuration Enhancements: Java 8 compileOptions have been added to the Teapot sample's build.gradle for improved compatibility, and the Gradle wrapper distribution URL was updated to gradle-6.2.2-all.zip.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This PR successfully addresses build errors by updating dependencies and tool versions for Android Studio 4.x compatibility. The changes, like updating SDK versions and migrating to a Maven dependency for Play Core, are positive. My review includes a high-priority recommendation to update the targetSdkVersion to match the compileSdkVersion to maintain compatibility and adhere to Google Play policies. I also have a medium-priority suggestion to refactor a function name in the C++ code for consistency after an API update.

[gemini-code-assist]

While you've correctly updated compileSdkVersion to 34, the targetSdkVersion on line 29 remains at 28. It is highly recommended to set targetSdkVersion to the same value as compileSdkVersion. Targeting a recent API level is a Google Play requirement for new apps and updates, and it ensures your app can leverage the latest platform features, security enhancements, and behavior changes. Failing to update it can lead to compatibility issues on newer Android devices.

[gemini-code-assist]

You've updated the code to use the newer AssetPackManager_showConfirmationDialog API, which is great. However, the containing function is still named ShowCellularDataConfirmation (line 224), and the log message on line 232 also refers to the old name. This creates an inconsistency that can be confusing for future maintenance. For better code clarity, I recommend renaming the function to ShowConfirmationDialog and updating the log message. This would also require updating the function declaration in PlayAssetDeliveryUtil.h and any places where it's called.