Create script for cherry picking to release branch#2234
Merged
copybara-service[bot] merged 3 commits intomainfrom Jun 26, 2024
Merged
Create script for cherry picking to release branch#2234copybara-service[bot] merged 3 commits intomainfrom
copybara-service[bot] merged 3 commits intomainfrom
Conversation
AkshDesai04
approved these changes
May 30, 2024
AkshDesai04
suggested changes
May 30, 2024
AkshDesai04
left a comment
AkshDesai04
left a comment
There was a problem hiding this comment.
Adding a call for git status ourselves would make it more functional.
if [[ -n $(git status -s) ]]; then
echo "Error: git directory is not clean; Running 'git status'"
git status
exit 1
fi
TWiStErRob
reviewed
May 30, 2024
| fi | ||
|
|
||
| if [[ ! "$RELEASE_BRANCH" =~ "release_branch" ]]; then | ||
| echo "Error: RELEASE_BRANCH env var is undefined or does not contain 'release_branch'" |
Contributor
There was a problem hiding this comment.
output the value to show which one?
Suggested change
| echo "Error: RELEASE_BRANCH env var is undefined or does not contain 'release_branch'" | |
| echo "Error: RELEASE_BRANCH env var (${RELEASE_BRANCH}) is undefined or does not contain 'release_branch'" |
AkshDesai04
reviewed
May 31, 2024
| set -e | ||
|
|
||
| if [[ -n $(git status -s) ]]; then | ||
| echo "Error: git directory is not clean; check 'git status'" |
There was a problem hiding this comment.
Suggested change
| echo "Error: git directory is not clean; check 'git status'" | |
| echo "Error: git directory is not clean; running 'git status'" | |
| git status |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.