Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates captureToBitmap in ViewCapture to treat API 34 the same way that all previous API works. #2074

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updates captureToBitmap in ViewCapture to treat API 34 the same way that all previous API works. #2074

wants to merge 1 commit into from

Commits on Dec 19, 2023

  1. Updates captureToBitmap in ViewCapture to treat API 34 the same way t… 

    …hat all previous API works.

Because API 34 wasn't getting the surface, it was including the action bar and messing up the screenshots. By removing it, it will use the surface instead and it works perfectly.

API 28 still does not work right with dialog boxes, but that is a known issue that we don't have a fix for yet.

To test this, I added tests for every API level and fixed a bug where the action bar wasn't showing up in the test.

PiperOrigin-RevId: 588915479
    @copybara-androidxtest
    copybara-androidxtest committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    56f67d2 View commit details
    Browse the repository at this point in the history